[RESEND 1/3] drm: fsl-dcu: Fix no fb check bug

Daniel Stone daniel at fooishbar.org
Mon Dec 28 07:14:44 PST 2015


Hi Stefan,

On Sunday, 27 December 2015, Stefan Agner <stefan at agner.ch> wrote:
>
> However, I think with my patch "drm/fsl-dcu: Fix no fb check bug", this
> situation can be avoided completely:
> https://lkml.org/lkml/2015/11/18/950
>
> With that patch applied, and a non-existing panel assigned, the DRM
> driver already fails at probe time gracefully:
> [    0.488291] [drm] Initialized drm 1.1.0 20060810
> [    0.501576] fsl-dcu 40058000.dcu: failed to initialize mode setting
>
> So I think that a state->fb check for NULL is not necessary at all...
>
> Can you test my patch to see if it fixes the issue for you too?
>

This is still required; state->fb being NULL means the plane is being
disabled.

Cheers,
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20151228/7c43fb37/attachment.html>


More information about the dri-devel mailing list