[PATCH v2 05/10] Add RGB666_1X24_CPADHI media bus format

[Sakari Ailus]

Hi Philipp,

Could you add linux-media next time you send the set, please? I think 
that's the most relevant list for the format related patches.

Philipp Zabel wrote:
> Commit 9e74d2926a28 ("staging: imx-drm: add LVDS666 support for parallel
> display") describes a 24-bit bus format where three 6-bit components each
> take the lower part of 8 bits with the two high bits zero padded. Add a
> component-wise padded media bus format RGB666_1X24_CPADHI to support this
> connection.
>
> Cc: Emil Renner Berthing <kernel at esmil.dk>
> Signed-off-by: Philipp Zabel <p.zabel at pengutronix.de>
> ---
>   Documentation/DocBook/media/v4l/subdev-formats.xml | 30 ++++++++++++++++++++++
>   include/uapi/linux/media-bus-format.h              |  3 ++-
>   2 files changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
> index 8d1f624..c02af7a 100644
> --- a/Documentation/DocBook/media/v4l/subdev-formats.xml
> +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
> @@ -480,6 +480,36 @@ see <xref linkend="colorspaces" />.</entry>
>   	      <entry>b<subscript>1</subscript></entry>
>   	      <entry>b<subscript>0</subscript></entry>
>   	    </row>
> +	    <row id="MEDIA-BUS-FMT-RGB666-1X24_CPADHI">
> +	      <entry>MEDIA_BUS_FMT_RGB666_1X24_CPADHI</entry>

Could you add a note on "C" in front of PADHI to the explanation in 
media-bus-format.h?

> +	      <entry>0x1015</entry>
> +	      <entry></entry>
> +	      &dash-ent-8;
> +	      <entry>0</entry>
> +	      <entry>0</entry>
> +	      <entry>r<subscript>5</subscript></entry>
> +	      <entry>r<subscript>4</subscript></entry>
> +	      <entry>r<subscript>3</subscript></entry>
> +	      <entry>r<subscript>2</subscript></entry>
> +	      <entry>r<subscript>1</subscript></entry>
> +	      <entry>r<subscript>0</subscript></entry>
> +	      <entry>0</entry>
> +	      <entry>0</entry>
> +	      <entry>g<subscript>5</subscript></entry>
> +	      <entry>g<subscript>4</subscript></entry>
> +	      <entry>g<subscript>3</subscript></entry>
> +	      <entry>g<subscript>2</subscript></entry>
> +	      <entry>g<subscript>1</subscript></entry>
> +	      <entry>g<subscript>0</subscript></entry>
> +	      <entry>0</entry>
> +	      <entry>0</entry>
> +	      <entry>b<subscript>5</subscript></entry>
> +	      <entry>b<subscript>4</subscript></entry>
> +	      <entry>b<subscript>3</subscript></entry>
> +	      <entry>b<subscript>2</subscript></entry>
> +	      <entry>b<subscript>1</subscript></entry>
> +	      <entry>b<subscript>0</subscript></entry>
> +	    </row>
>   	    <row id="MEDIA-BUS-FMT-BGR888-1X24">
>   	      <entry>MEDIA_BUS_FMT_BGR888_1X24</entry>
>   	      <entry>0x1013</entry>
> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
> index 8dbf16c..83ea46f 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -33,7 +33,7 @@
>
>   #define MEDIA_BUS_FMT_FIXED			0x0001
>
> -/* RGB - next is	0x1015 */
> +/* RGB - next is	0x1016 */
>   #define MEDIA_BUS_FMT_RGB444_1X12		0x100e
>   #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE	0x1001
>   #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE	0x1002
> @@ -45,6 +45,7 @@
>   #define MEDIA_BUS_FMT_RGB565_2X8_BE		0x1007
>   #define MEDIA_BUS_FMT_RGB565_2X8_LE		0x1008
>   #define MEDIA_BUS_FMT_RGB666_1X18		0x1009
> +#define MEDIA_BUS_FMT_RGB666_1X24_CPADHI	0x1015
>   #define MEDIA_BUS_FMT_RGB666_1X7X3_SPWG		0x1010
>   #define MEDIA_BUS_FMT_BGR888_1X24		0x1013
>   #define MEDIA_BUS_FMT_GBR888_1X24		0x1014
>

-- 
Kind regards,

Sakari Ailus
sakari.ailus at linux.intel.com