[Intel-gfx] [RFC v3 3/4] drm/i915: Add new panel driver based on crystal cove pmic

[Daniel Vetter]

On Tue, Feb 03, 2015 at 02:16:53PM +0100, Thierry Reding wrote:
> On Wed, Jan 21, 2015 at 04:48:12PM +0530, Shobhit Kumar wrote:
> > diff --git a/drivers/gpu/drm/i915/intel-panel-crystalcove.c b/drivers/gpu/drm/i915/intel-panel-crystalcove.c
> [...]
> > +#define PMIC_PANEL_EN		0x52
> > +#define PMIC_PWM_EN		0x51
> > +#define PMIC_BKL_EN		0x4B
> > +#define PMIC_PWM_LEVEL		0x4E
> 
> These look like they should be GPIOs/regulators and a PWM instead. So I
> think you'd need to further split up the MFD device to accomodate for
> this.

I've had some extension discussion with Thierry on irc and I agree that
using gpio/pwm interfaces will suit better. In addition both gpio and pwm
subsystem already have magic register/lookup support (which works outside
of devicetree or the new acpi tables, which I didn't know). So we'll avoid
writing our own inter-module boilerplate.

Shobhit, Jani&I also chatted about this topic on irc and I think the rough
direction is hopefully clear now.

Just a quick mail here for the record so that the irc discussion won't get
lost.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch