[PATCH 4/4] drm/exynos: fix NULL pointer reference

Gustavo Padovan gustavo at padovan.org
Fri Feb 6 04:44:33 PST 2015


Hi,

2015-02-06 Joonyoung Shim <jy0922.shim at samsung.com>:

> Hi,
> 
> On 02/05/2015 10:07 PM, Gustavo Padovan wrote:
> > Hi,
> > 
> > 
> > 2015-02-05 Joonyoung Shim <jy0922.shim at samsung.com>:
> > 
> >> There is a case called disable_plane callback function even if
> >> plane->crtc is NULL from exynos_drm_encoder_disable and it will cause
> >> NULL pointer reference error.
> >>
> >> Signed-off-by: Joonyoung Shim <jy0922.shim at samsung.com>
> >> ---
> >>  drivers/gpu/drm/exynos/exynos_drm_encoder.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > You need to merge this patch with patch 3 or you will break the bisect.
> > The NULL pointer is introduced by the previous patch, so fix it in the same
> > patch.
> > 
> 
> Yeah, it is revealed by patch 3 but it was original problem from before
> patch 3. How about apply this patch earlier than patch 3?

Okay. That sounds good too.

	Gustavo


More information about the dri-devel mailing list