[PATCH 2/2] drm/msm/hdmi: add hdmi hdcp support (V2)
Bjorn Andersson
bjorn at kryo.se
Tue Feb 10 11:34:00 PST 2015
On Fri, Jan 30, 2015 at 2:39 PM, Bjorn Andersson <bjorn at kryo.se> wrote:
> On Fri, Jan 30, 2015 at 1:51 PM, Bjorn Andersson <bjorn at kryo.se> wrote:
>> On Tue, Jan 13, 2015 at 12:43 PM, Jilai Wang <jilaiw at codeaurora.org> wrote:
>>> Add HDMI HDCP support including HDCP PartI/II/III authentication.
>>> V1: Initial Change
>>> V2: Address Bjorn&Rob's comments
>>> Refactor the authentication process to use single work instead
>>> of multiple work for different authentication stages.
>>>
>> Looks cleaner and the SCM parts look good now.
>>
>> But the ddc communication still makes me wonder, see below.
>>
>
> Rob made me aware about the fact that the hdmi driver is both
> implementing a driver for the i2c controller and now for the hdcp
> client and hence doesn't have an i2c_client handle.
>
> So unless this is redesigned to be split in a separate i2c client
> driver we probably have to have the ddc functions like this.
>
> I'm fine with this as is for now.
>
After digging some more in the i2c stack I found others using
i2c_new_dummy() to create a "dummy" i2c client from and adaptor and an
address.
By introducing that we could make hdmi->i2c an actual i2c_client and
use the client api in here.
Regards,
Bjorn
More information about the dri-devel
mailing list