[PATCH 04/15] tests/exynos: disable the G2D userptr/blend test

Joonyoung Shim jy0922.shim at samsung.com
Tue Feb 10 17:11:43 PST 2015


Hi,

On 02/03/2015 10:53 PM, Tobias Jakobi wrote:
> The blend test uses the userptr functionality of exynos-drm, which
> is currently not safe to use. If the kernel hasn't been build with
> exynos-iommu support, then the blend test is going to produce (kernel)
> memory corruption, eventually leading to a system crash.
> 
> Disable the test for now, until the kernel code has been sanitized.
> 
> Signed-off-by: Tobias Jakobi <tjakobi at math.uni-bielefeld.de>
> ---
>  tests/exynos/exynos_fimg2d_test.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c
> index aa140e5..48dfe97 100644
> --- a/tests/exynos/exynos_fimg2d_test.c
> +++ b/tests/exynos/exynos_fimg2d_test.c
> @@ -788,11 +788,13 @@ int main(int argc, char **argv)
>  
>  	getchar();
>  
> +#if 0

How about add some comments about why need disable?

Thanks.

>  	ret  = test_case.blend(dev, src, bo, G2D_IMGBUF_USERPTR);
>  	if (ret < 0)
>  		fprintf(stderr, "failed to test blend operation.\n");
>  
>  	getchar();
> +#endif
>  
>  err_free_src:
>  	if (src)
> 



More information about the dri-devel mailing list