[GIT PULL]: few dma-buf updates for 3.20-rc1

Linus Torvalds torvalds at linux-foundation.org
Sat Feb 21 12:12:38 PST 2015


On Fri, Feb 20, 2015 at 8:27 AM, Sumit Semwal <sumit.semwal at linaro.org> wrote:
>
> Could you please pull a few dma-buf changes for 3.20-rc1? Nothing
> fancy, minor cleanups.

No.

I pulled, and immediately unpulled again.

This is complete shit, and the compiler even tells you so:

    drivers/staging/android/ion/ion.c: In function ‘ion_share_dma_buf’:
    drivers/staging/android/ion/ion.c:1112:24: warning: ‘buffer’ is
used uninitialized in this function [-Wuninitialized]
     exp_info.size = buffer->size;
                            ^

Introduced by "dma-buf: cleanup dma_buf_export() to make it easily extensible".

I'm not taking "cleanups" like this.  And I certainly don't appreciate
being sent completely bogus shit pull requests at the end of the merge
cycle.

                           Linus


More information about the dri-devel mailing list