[PATCH 4/4] drm/sysfs: remove unnecessary connector type checks
Jani Nikula
jani.nikula at intel.com
Tue Feb 24 05:08:03 PST 2015
These attributes should be exposed for the matching connector types
only, so checking is redundant.
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
---
drivers/gpu/drm/drm_sysfs.c | 32 --------------------------------
1 file changed, 32 deletions(-)
diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
index d18c5aac6935..60b9f136ac44 100644
--- a/drivers/gpu/drm/drm_sysfs.c
+++ b/drivers/gpu/drm/drm_sysfs.c
@@ -267,17 +267,6 @@ static ssize_t tv_subconnector_show(struct device *device,
uint64_t subconnector;
int ret;
- switch (connector->connector_type) {
- case DRM_MODE_CONNECTOR_Composite:
- case DRM_MODE_CONNECTOR_SVIDEO:
- case DRM_MODE_CONNECTOR_Component:
- case DRM_MODE_CONNECTOR_TV:
- break;
- default:
- DRM_ERROR("Wrong connector type for this property\n");
- return 0;
- }
-
prop = dev->mode_config.tv_subconnector_property;
if (!prop) {
DRM_ERROR("Unable to find subconnector property\n");
@@ -302,17 +291,6 @@ static ssize_t tv_select_subconnector_show(struct device *device,
uint64_t subconnector;
int ret;
- switch (connector->connector_type) {
- case DRM_MODE_CONNECTOR_Composite:
- case DRM_MODE_CONNECTOR_SVIDEO:
- case DRM_MODE_CONNECTOR_Component:
- case DRM_MODE_CONNECTOR_TV:
- break;
- default:
- DRM_ERROR("Wrong connector type for this property\n");
- return 0;
- }
-
prop = dev->mode_config.tv_select_subconnector_property;
if (!prop) {
DRM_ERROR("Unable to find select subconnector property\n");
@@ -337,11 +315,6 @@ static ssize_t dvii_subconnector_show(struct device *device,
uint64_t subconnector;
int ret;
- if (connector->connector_type != DRM_MODE_CONNECTOR_DVII) {
- DRM_ERROR("Wrong connector type for this property\n");
- return 0;
- }
-
prop = dev->mode_config.dvi_i_subconnector_property;
if (!prop) {
DRM_ERROR("Unable to find subconnector property\n");
@@ -366,11 +339,6 @@ static ssize_t dvii_select_subconnector_show(struct device *device,
uint64_t subconnector;
int ret;
- if (connector->connector_type != DRM_MODE_CONNECTOR_DVII) {
- DRM_ERROR("Wrong connector type for this property\n");
- return 0;
- }
-
prop = dev->mode_config.dvi_i_select_subconnector_property;
if (!prop) {
DRM_ERROR("Unable to find select subconnector property\n");
--
2.1.4
More information about the dri-devel
mailing list