[PATCH] gpu: drm: gma500: mmu.c: Remove unused function

Patrik Jakobsson patrik.r.jakobsson at gmail.com
Thu Jan 1 12:04:15 PST 2015


On Thu, Jan 1, 2015 at 5:55 PM, Rickard Strandqvist
<rickard_strandqvist at spectrumdigital.se> wrote:
> Remove the function psb_get_default_pd_addr() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist at spectrumdigital.se>

Hej Rickard

I'd like to keep that function since it's relevant to getting the MSVDX running.
I'm not working on it but someone else might be.

> ---
>  drivers/gpu/drm/gma500/mmu.c |    9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c
> index 0eaf11c..557cae7 100644
> --- a/drivers/gpu/drm/gma500/mmu.c
> +++ b/drivers/gpu/drm/gma500/mmu.c
> @@ -426,15 +426,6 @@ struct psb_mmu_pd *psb_mmu_get_default_pd(struct psb_mmu_driver *driver)
>         return pd;
>  }
>
> -/* Returns the physical address of the PD shared by sgx/msvdx */
> -uint32_t psb_get_default_pd_addr(struct psb_mmu_driver *driver)
> -{
> -       struct psb_mmu_pd *pd;
> -
> -       pd = psb_mmu_get_default_pd(driver);
> -       return page_to_pfn(pd->p) << PAGE_SHIFT;
> -}
> -
>  void psb_mmu_driver_takedown(struct psb_mmu_driver *driver)
>  {
>         struct drm_device *dev = driver->dev;
> --
> 1.7.10.4
>


More information about the dri-devel mailing list