drm: Remove useless else block

Dan Carpenter dan.carpenter at oracle.com
Fri Jan 9 20:48:23 PST 2015


Hi Dave,

There is a bad merge in drm-next and it causes a static checker warning.

The patch 2ca651d15aff: "drm: Remove useless else block" from Dec 10,
2014, leads to the following static checker warning:

	drivers/gpu/drm/drm_crtc.c:4380 drm_property_change_valid_get()
	info: ignoring unreachable code.

drivers/gpu/drm/drm_crtc.c
  4371                  }
  4372          } else {
  4373                  int i;
  4374                  for (i = 0; i < property->num_values; i++)
  4375                          if (property->values[i] == value)
  4376                                  return true;
  4377                  return false;
  4378          }
  4379  
  4380          for (i = 0; i < property->num_values; i++)
  4381                  if (property->values[i] == value)
  4382                          return true;
  4383          return false;

This block was in the else statement before, but now it's moved to here
as well.

  4384  }

regards,
dan carpenter


More information about the dri-devel mailing list