[PATCH] drm: nouveau: core: engine: perfmon: base: Remove unused function
Samuel Pitoiset
samuel.pitoiset at gmail.com
Sun Jan 11 13:00:05 PST 2015
Hi Rickard,
Thanks for submitting this patch, but I already submitted the same a few
weeks ago. :-)
This function will be removed when I will submit my work on this area.
Greetings,
Samuel Pitoiset.
On 01/11/2015 07:12 PM, Rickard Strandqvist wrote:
> Remove the function nouveau_perfsig_wrap() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist at spectrumdigital.se>
> ---
> drivers/gpu/drm/nouveau/core/engine/perfmon/base.c | 20 --------------------
> drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h | 5 -----
> 2 files changed, 25 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c b/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c
> index 6301381..d0c5255 100644
> --- a/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c
> +++ b/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c
> @@ -80,26 +80,6 @@ nouveau_perfsig_find(struct nouveau_perfmon *ppm, const char *name, u32 size,
> return nouveau_perfsig_find_(dom, name, size);
> }
>
> -struct nouveau_perfctr *
> -nouveau_perfsig_wrap(struct nouveau_perfmon *ppm, const char *name,
> - struct nouveau_perfdom **pdom)
> -{
> - struct nouveau_perfsig *sig;
> - struct nouveau_perfctr *ctr;
> -
> - sig = nouveau_perfsig_find(ppm, name, strlen(name), pdom);
> - if (!sig)
> - return NULL;
> -
> - ctr = kzalloc(sizeof(*ctr), GFP_KERNEL);
> - if (ctr) {
> - ctr->signal[0] = sig;
> - ctr->logic_op = 0xaaaa;
> - }
> -
> - return ctr;
> -}
> -
> /*******************************************************************************
> * Perfmon object classes
> ******************************************************************************/
> diff --git a/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h b/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h
> index 0ac8714..1a0989e 100644
> --- a/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h
> +++ b/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h
> @@ -30,11 +30,6 @@ struct nouveau_perfsig {
> const char *name;
> };
>
> -struct nouveau_perfdom;
> -struct nouveau_perfctr *
> -nouveau_perfsig_wrap(struct nouveau_perfmon *, const char *,
> - struct nouveau_perfdom **);
> -
> struct nouveau_specdom {
> u16 signal_nr;
> const struct nouveau_specsig *signal;
More information about the dri-devel
mailing list