[PATCH] drm/exynos: remove unnecessary runtime pm operations

Joonyoung Shim jy0922.shim at samsung.com
Mon Jan 12 21:43:07 PST 2015


In booting, we can see a below message.

[    3.241728] exynos-mixer 14450000.mixer: Unbalanced pm_runtime_enable!

Already pm_runtime_enable is called by probe function. Remove
pm_runtime_enable/disable from mixer_bind and mixer_unbind.

Signed-off-by: Joonyoung Shim <jy0922.shim at samsung.com>
---
I'm not sure whether it's better to remove pm_runtime_enable/disable
from probe and remove function than mixer_bind and mixer_unbind.

 drivers/gpu/drm/exynos/exynos_mixer.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
index b90a423..0dedb99 100644
--- a/drivers/gpu/drm/exynos/exynos_mixer.c
+++ b/drivers/gpu/drm/exynos/exynos_mixer.c
@@ -1256,8 +1256,6 @@ static int mixer_bind(struct device *dev, struct device *manager, void *data)
 	if (ret)
 		goto free_ctx;
 
-	pm_runtime_enable(dev);
-
 	return 0;
 
 free_ctx:
@@ -1270,8 +1268,6 @@ static void mixer_unbind(struct device *dev, struct device *master, void *data)
 	struct mixer_context *ctx = dev_get_drvdata(dev);
 
 	mixer_ctx_remove(ctx);
-
-	pm_runtime_disable(dev);
 }
 
 static const struct component_ops mixer_component_ops = {
-- 
1.9.1



More information about the dri-devel mailing list