[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

Jean-Francois Moine moinejf at free.fr
Tue Jan 13 01:24:55 PST 2015


On Fri, 09 Jan 2015 17:39:08 +0000
Andrew Jackson <Andrew.Jackson at arm.com> wrote:

> > +       snd_pcm_hw_constraint_minmax(runtime,
> > +                               SNDRV_PCM_HW_PARAM_CHANNELS,
> > +                               1, sad[SAD_MX_CHAN_I]);  
> 
> In the light of our discussions elsewhere [1], shouldn't this
> be constrained by the number of hardware channels that the TDA998x
> supports too?  That is, the maximum number of channels should
> be the lesser of sd[SAD_MX_CHAN_I] and number_of_I2S channels 
> (or S/PDIF channels if so configured).

snd_pcm_hw_constraint_minmax() does the job from the min/max numbers of
channels in the DAI definition and the real max number of channels will
be set from audio ports declared in the DT.

-- 
Ken ar c'hentaƱ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/


More information about the dri-devel mailing list