[PATCH] drm/vmwgfx: Replace the hw mutex with a hw spinlock

Dave Airlie airlied at gmail.com
Tue Jan 20 15:45:21 PST 2015


On 19 January 2015 at 21:03, Thomas Hellstrom <thellstrom at vmware.com> wrote:
> Fixes a case where we call vmw_fifo_idle() from within a wait function with
> task state !TASK_RUNNING, which is illegal.
>
> In addition, make the locking fine-grained, so that it is performed once
> for every read- and write operation. This is of course more costly, but we
> don't perform much register access in the timing critical paths anyway. Instead
> we have the extra benefit of being sure that we don't forget the hw lock around
> register accesses. I think currently the kms code was quite buggy w r t this.

So what is your feeling on this for -fixes?

Dave.


More information about the dri-devel mailing list