[PATCH libdrm 06/11] xf86drmMode.h: Use consistent padding

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sat Jan 24 15:26:52 PST 2015


Hi Thierry,

Thank you for the patch.

On Friday 23 January 2015 17:08:19 Thierry Reding wrote:
> From: Thierry Reding <treding at nvidia.com>
> 
> Signed-off-by: Thierry Reding <treding at nvidia.com>
> ---
>  xf86drmMode.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/xf86drmMode.h b/xf86drmMode.h
> index 856a6bb0f569..e70c16d437f4 100644
> --- a/xf86drmMode.h
> +++ b/xf86drmMode.h
> @@ -123,13 +123,13 @@ extern "C" {
>  #define DRM_MODE_DITHERING_OFF  0
>  #define DRM_MODE_DITHERING_ON   1
> 
> -#define DRM_MODE_ENCODER_NONE   0
> -#define DRM_MODE_ENCODER_DAC    1
> -#define DRM_MODE_ENCODER_TMDS   2
> -#define DRM_MODE_ENCODER_LVDS   3
> -#define DRM_MODE_ENCODER_TVDAC  4
> +#define DRM_MODE_ENCODER_NONE    0
> +#define DRM_MODE_ENCODER_DAC     1
> +#define DRM_MODE_ENCODER_TMDS    2
> +#define DRM_MODE_ENCODER_LVDS    3
> +#define DRM_MODE_ENCODER_TVDAC   4
>  #define DRM_MODE_ENCODER_VIRTUAL 5
> -#define DRM_MODE_ENCODER_DSI	6
> +#define DRM_MODE_ENCODER_DSI     6

Nitpicking here, I would have aligned everything on the same column for every 
block of #define's, but that's up to you.

> 
>  #define DRM_MODE_SUBCONNECTOR_Automatic 0
>  #define DRM_MODE_SUBCONNECTOR_Unknown   0
> @@ -153,8 +153,8 @@ extern "C" {
>  #define DRM_MODE_CONNECTOR_DisplayPort  10
>  #define DRM_MODE_CONNECTOR_HDMIA        11
>  #define DRM_MODE_CONNECTOR_HDMIB        12
> -#define DRM_MODE_CONNECTOR_TV		13
> -#define DRM_MODE_CONNECTOR_eDP		14
> +#define DRM_MODE_CONNECTOR_TV           13
> +#define DRM_MODE_CONNECTOR_eDP          14
>  #define DRM_MODE_CONNECTOR_VIRTUAL      15
>  #define DRM_MODE_CONNECTOR_DSI          16

-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list