[PATCH 1/2] exynos: Don't use DRM_EXYNOS_GEM_{MAP_OFFSET/MMAP} ioctls

Emil Velikov emil.l.velikov at gmail.com
Mon Jan 26 18:56:49 PST 2015


On 27 January 2015 at 01:05, Hyungwon Hwang <human.hwang at samsung.com> wrote:
> Dear Emil,
>
> On Mon, 26 Jan 2015 19:05:51 +0000
> Emil Velikov <emil.l.velikov at gmail.com> wrote:
>
>> On 26 January 2015 at 01:42, Hyungwon Hwang <human.hwang at samsung.com>
>> wrote:
>> > Dear Tobias,
>> >
>> > Thanks for fixing it.
>> >
>> > Signed-off-by: Hyungwon Hwang <human.hwang at samsung.com>
>> >
>> Hi Hyungwon Hwang
>>
>> I'm a bit confused about the use of s-o-b here. I've assumed that
>> libdrm follows the kernel style [1] for those type of things ?
>> Would you have anything handy which I can read on the topic ?
>
> I also think that DRI-devel mailing list follow the kernel rule.
Sweet I'm not loosing my mind (much).

[...]
> Was it wrong to add s-o-b here? Should I have used "Reviewed-by" here?
> I am sorry, if I broke the rule and confused you.
>
Don't think any apology is due, I was just hinting that the patch has
the s-o-b already :P
Where as "what I should have used" that depends on your intent and/or
the action undertaken.

Thanks
Emil


More information about the dri-devel mailing list