[PATCH] drm: bridge/dw_hdmi: Fix return error path

Thierry Reding thierry.reding at gmail.com
Wed Jan 28 00:00:53 PST 2015


On Tue, Jan 27, 2015 at 04:17:51PM +0100, Philipp Zabel wrote:
> Hi Fabio,
> 
> Am Dienstag, den 27.01.2015, 10:54 -0200 schrieb Fabio Estevam:
> > If devm_request_threaded_irq() fails we should jump to 'err_iahb' label that 
> > will disable the clocks that were previously enabled.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> > ---
> >  drivers/gpu/drm/bridge/dw_hdmi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> > index ed3dfe7..cd6a706 100644
> > --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> > +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
> > @@ -1642,7 +1642,7 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
> >  					dw_hdmi_irq, IRQF_SHARED,
> >  					dev_name(dev), hdmi);
> >  	if (ret)
> > -		return ret;
> > +		goto err_iahb;
> >  
> >  	/*
> >  	 * To prevent overflows in HDMI_IH_FC_STAT2, set the clk regenerator
> 
> Thanks for the fix. I have applied this to my tree since I've introduced
> the bug in there.

I'm currently redoing the drm/{panel,bridge} pull request anyway, so I
could apply this while at it.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150128/3112241e/attachment-0001.sig>


More information about the dri-devel mailing list