[PATCH] drm/bridge: dw_hdmi: Return the real error on drm_bridge_attach() failure

Fabio Estevam festevam at gmail.com
Thu Jan 29 02:48:22 PST 2015


From: Fabio Estevam <fabio.estevam at freescale.com>

drm_bridge_attach() may return different errors on failure, not just -EINVAL, so
it is better to propagate the real error instead.

Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
---
 drivers/gpu/drm/bridge/dw_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index cd6a706..fcae66a 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -1528,7 +1528,7 @@ static int dw_hdmi_register(struct drm_device *drm, struct dw_hdmi *hdmi)
 	ret = drm_bridge_attach(drm, bridge);
 	if (ret) {
 		DRM_ERROR("Failed to initialize bridge with drm\n");
-		return -EINVAL;
+		return ret;
 	}
 
 	encoder->bridge = bridge;
-- 
1.9.1



More information about the dri-devel mailing list