[PATCH 6/6] drm/exynos: do not copy adjusted mode into mode during crtc mode_set

Gustavo Padovan gustavo at padovan.org
Fri Jan 30 06:44:20 PST 2015


Hi Joonyoung,

2015-01-30 Joonyoung Shim <jy0922.shim at samsung.com>:

> Hi,
> 
> On 01/23/2015 09:43 PM, Gustavo Padovan wrote:
> > From: Daniel Kurtz <djkurtz at chromium.org>
> > 
> > The 'mode' is the modeline information which specifies the ideal mode
> > requested by the mode set initiator (usually userspace).
> > The 'adjusted_mode' is the actual hardware mode after all the crtcs
> > and encoders have had a chance to "fix it up".
> > 
> > The adjusted_mode starts as a duplicate of the mode in
> > drm_crtc_helper_set_mode(), and gets modified as required.  There is no
> > reason to touch the original requested mode.
> > 
> 
> Agree, but is there any side effect after this commit? Should we save
> adjusted_mode to other variable and use it?

I haven't seen any. Tested on peach pi and snow. Do we have any reason to save
it now? I don't we have a user for it now.

	Gustavo


More information about the dri-devel mailing list