[PATCH -v2] drm/exynos: track vblank events on a per crtc basis

Daniel Stone daniel at fooishbar.org
Fri Jan 30 07:57:53 PST 2015


Hi,

On 30 January 2015 at 14:30, Gustavo Padovan <gustavo at padovan.org> wrote:
> 2015-01-30 Joonyoung Shim <jy0922.shim at samsung.com>:
>> We will lose unfinished prior events by this change. That's why we use
>> linked list.
>
> I think you are right, but I was using exynos_crtc->event to do exactly the
> same as exynos_crtc->pending_flip. So we were losing a event in
> exynos_drm_crtc_dpms() before too. I change this patch to have a page_flip
> list on the crtc.

The usual approach in other drivers is to return -EBUSY when there is
already an async pageflip pending. This definitely makes sense to me,
as I don't see the point of submitting pageflips faster than the
hardware can actually render, and pretending to the application that
they were actually shown.

Cheers,
Daniel


More information about the dri-devel mailing list