[PATCH v2 10/12] drm/tegra: Suspend dc/dsi/panel in one-shot mode

[Mark Zhang]

On 07/01/2015 05:00 PM, Daniel Vetter wrote:
> On Wed, Jul 01, 2015 at 04:21:53PM +0800, Mark Zhang wrote:
>> @@ -756,7 +752,11 @@ tegra_dsi_connector_duplicate_state(struct drm_connector *connector)
>>  }
>>  
>>  static const struct drm_connector_funcs tegra_dsi_connector_funcs = {
>> -	.dpms = tegra_dsi_connector_dpms,
>> +	/*
>> +	 * drm_atomic_helper_connector_dpms only handles DPMS ON/OFF,
>> +	 * so use drm_helper_connector_dpms instead.
>> +	 */
>> +	.dpms = drm_helper_connector_dpms,
> 
> Nope, mixing legacy dpms handling into an atomic driver is a no-go. You
> need to use drm_atomic_helper_connector_dpms here.

yeah, so I have to change "drm_atomic_helper_connector_dpms"?

Mark
> -Daniel
>