[PATCH 1/2] drm/ttm: fix uncached page deallocation to properly fill page pool v3.

Alex Deucher alexdeucher at gmail.com
Thu Jul 9 11:24:29 PDT 2015


On Thu, Jul 9, 2015 at 2:19 PM,  <j.glisse at gmail.com> wrote:
> From: Jérôme Glisse <jglisse at redhat.com>
>
> Current code never allowed the page pool to actualy fill in anyway.
> This fix it, so that we only start freeing page from the pool when
> we go over the pool size.
>
> Changed since v1:
>   - Move the page batching optimization to its separate patch.
>
> Changed since v2:
>   - Do not remove code part of the batching optimization with
>     this patch.
>   - Better commit message.
>
> Signed-off-by: Jérôme Glisse <jglisse at redhat.com>
> Reviewed-by: Mario Kleiner <mario.kleiner.de at gmail.com>
> Reviewed-and-Tested-by: Michel Dänzer <michel.daenzer at amd.com>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk at oracle.com>
> Cc: Thomas Hellstrom <thellstrom at vmware.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
> index 3077f15..af23080 100644
> --- a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
> +++ b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
> @@ -963,7 +963,6 @@ void ttm_dma_unpopulate(struct ttm_dma_tt *ttm_dma, struct device *dev)
>         } else {
>                 pool->npages_free += count;
>                 list_splice(&ttm_dma->pages_list, &pool->free_list);
> -               npages = count;
>                 if (pool->npages_free > _manager->options.max_size) {
>                         npages = pool->npages_free - _manager->options.max_size;
>                         /* free at least NUM_PAGES_TO_ALLOC number of pages
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list