[PATCH] drm/exynos/fimc: fix runtime pm support

Tobias Jakobi tjakobi at math.uni-bielefeld.de
Sun Jul 12 09:24:59 PDT 2015


Hello,

looks like this patch was forgotten. At least I can't find it in 4.2-rc1.

With best wishes,
Tobias


Marek Szyprowski wrote:
> Once pm_runtime_set_active() gets called, the kernel assumes that given
> device has already enabled runtime pm and will call pm_runtime_suspend()
> without matching pm_runtime_resume(). In case of DRM FIMC IPP driver,
> this will result in calling clk_disable() without respective call to
> clk_enable(). This patch removes call to pm_runtime_set_active() to
> ensure that pm_runtime_suspend/resume calls will match.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> index 842d6b8dc3c4..2a652359af64 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> @@ -1745,7 +1745,6 @@ static int fimc_probe(struct platform_device *pdev)
>  	spin_lock_init(&ctx->lock);
>  	platform_set_drvdata(pdev, ctx);
>  
> -	pm_runtime_set_active(dev);
>  	pm_runtime_enable(dev);
>  
>  	ret = exynos_drm_ippdrv_register(ippdrv);
> 



More information about the dri-devel mailing list