[RFC v2 0/6] drm: fb emulation: Step 2: Create a fbdev emulation config option

Daniel Vetter daniel at ffwll.ch
Mon Jul 13 00:15:01 PDT 2015


On Mon, Jul 13, 2015 at 12:12:05PM +0530, Archit Taneja wrote:
> This provides a uniform interface to enable/disable legacy fbdev support
> for modesetting drivers.
> 
> DRM_FBDEV_EMULATION is made available in the top level drm Kconfig. A
> driver that wants fbdev emulation using drm_fb_helper can enable this
> option.
> 
> Apart from 5 drivers (msm, tegra, imx, sti, i915), all enable fbdev
> emulation by default. For these drivers, if we explicitly disable fbdev
> emulation, the 'hope' is that we will cleanly bail out with an error. We
> set DRM_FBDEV_EMULATION to 'y' by default, since most drivers rely on it.
> 
> 
> Archit Taneja (6):
>   drm: Add top level Kconfig option for DRM fbdev emulation
>   drm/msm: Remove local fbdev emulation Kconfig option
>   drm/tegra: Remove local fbdev emulation Kconfig option
>   drm/imx: Remove local fbdev emulation Kconfig option
>   drm/sti: Remove local fbdev emulation Kconfig option
>   drm/i915: Remove local fbdev emulation Kconfig option

Ah I guess you can disregard some of my comments here. Since this was
in-reply-to the old thread but step 1 wasn't I've read the patches
out-of-order ;-)
-Daniel

> 
>  drivers/gpu/drm/Kconfig              |  12 +++
>  drivers/gpu/drm/Makefile             |   2 +-
>  drivers/gpu/drm/i915/Kconfig         |  15 ---
>  drivers/gpu/drm/i915/Makefile        |   4 +-
>  drivers/gpu/drm/i915/i915_debugfs.c  |   2 +-
>  drivers/gpu/drm/i915/i915_drv.h      |   2 -
>  drivers/gpu/drm/i915/intel_display.c |  10 +-
>  drivers/gpu/drm/i915/intel_dp_mst.c  |  14 +--
>  drivers/gpu/drm/i915/intel_drv.h     |   3 +-
>  drivers/gpu/drm/i915/intel_fbdev.c   |   7 --
>  drivers/gpu/drm/imx/Kconfig          |   9 --
>  drivers/gpu/drm/imx/imx-drm-core.c   |  10 +-
>  drivers/gpu/drm/msm/Kconfig          |  14 ---
>  drivers/gpu/drm/msm/Makefile         |   2 +-
>  drivers/gpu/drm/msm/msm_drv.c        |   8 +-
>  drivers/gpu/drm/sti/Kconfig          |   6 --
>  drivers/gpu/drm/sti/sti_drm_drv.c    |   2 +-
>  drivers/gpu/drm/tegra/Kconfig        |  12 ---
>  drivers/gpu/drm/tegra/drm.c          |  15 ++-
>  drivers/gpu/drm/tegra/drm.h          |   8 --
>  drivers/gpu/drm/tegra/fb.c           |  25 ++---
>  include/drm/drm_fb_helper.h          | 192 +++++++++++++++++++++++++++++++++++
>  22 files changed, 242 insertions(+), 132 deletions(-)
> 
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list