[PATCH libdrm 3/4] xf86drm: fix incorrect fd comparison in drmOpenOnce{, WithType}

Emil Velikov emil.l.velikov at gmail.com
Tue Jul 14 07:10:04 PDT 2015


Spotted by looking for similar "let's assume fd == 0 is invalid" bugs.

Cc: Thierry Reding <thierry.reding at gmail.com>
Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
---
 xf86drm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xf86drm.c b/xf86drm.c
index 2c17d11..39c6e2d 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -2619,7 +2619,7 @@ int drmOpenOnceWithType(const char *BusID, int *newlyopened, int type)
 	}
 
     fd = drmOpenWithType(NULL, BusID, type);
-    if (fd <= 0 || nr_fds == DRM_MAX_FDS)
+    if (fd < 0 || nr_fds == DRM_MAX_FDS)
 	return fd;
    
     connection[nr_fds].BusID = strdup(BusID);
-- 
2.4.5



More information about the dri-devel mailing list