[PATCH] libdrm/amdgpu: Fixed drm.h include.

[Alexandr Akulich]

As I see, this is not a kernel header, but a local (belongs to libdrm) one.
(Otherwise, I would like you to point me on such file at, say,
https://github.com/torvalds/linux/tree/master/include/drm)

At files drm_sarea.h, mga_drm.h, qxl_drm.h, radeon_drm.h and via_drm.h we have

#include "drm.h"

At the same time, at i915_drm.h and tegra_drm.h. we have

#include <drm.h>

I'm pretty sure that the first case is correct, because drm.h is
always would be local file (in the same directory), related to
amdgpu_drm.h, and that is why local include "drm.h" would be always
valid.

This fixes libdrm build with amdgpu support on bare system for me.


On Fri, Jul 17, 2015 at 2:13 PM, Michel Dänzer <michel at daenzer.net> wrote:
> On 17.07.2015 05:19, akulichalexander at gmail.com wrote:
>> From: Alexandr Akulich <akulichalexander at gmail.com>
>>
>> The include type changed from system to own.
>>
>> Signed-off-by: Alexandr Akulich <akulichalexander at gmail.com>
>> ---
>>  include/drm/amdgpu_drm.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h
>> index b6fce90..25e9b0a 100644
>> --- a/include/drm/amdgpu_drm.h
>> +++ b/include/drm/amdgpu_drm.h
>> @@ -32,7 +32,7 @@
>>  #ifndef __AMDGPU_DRM_H__
>>  #define __AMDGPU_DRM_H__
>>
>> -#include <drm/drm.h>
>> +#include "drm.h"
>>
>>  #define DRM_AMDGPU_GEM_CREATE          0x00
>>  #define DRM_AMDGPU_GEM_MMAP            0x01
>>
>
> It should be
>
> #include <drm.h>
>
> <drm/drm.h> is wrong because that's the path of the kernel header, which
> not every distro ships.
>
> "drm.h" is wrong because amdgpu_drm.h is used by other projects.
>
>
> --
> Earthling Michel Dänzer               |               http://www.amd.com
> Libre software enthusiast             |             Mesa and X developer