[PATCH 1/2] drm/radeon: Drop drm/ prefix for including drm.h in radeon_drm.h

Daniel Vetter daniel at ffwll.ch
Wed Jul 22 02:33:53 PDT 2015


On Wed, Jul 22, 2015 at 06:16:41PM +0900, Michel Dänzer wrote:
> On 22.07.2015 18:16, Daniel Vetter wrote:
> > On Wed, Jul 22, 2015 at 10:38:18AM +0200, Christian König wrote:
> >> On 22.07.2015 10:29, Michel Dänzer wrote:
> >>> From: Michel Dänzer <michel.daenzer at amd.com>
> >>>
> >>> This allows radeon_drm.h to be reused verbatim in libdrm.
> >>>
> >>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> >>
> >> For both patches Reviewed-by: Christian König <christian.koenig at amd.com>
> > 
> > #ifdef __KERNEL__
> > #include <drm/drm.h>
> > #else
> > #include <drm.h>
> > #endif
> > 
> > then run
> > 
> > $ make headers_install
> > 
> > and copy results verbatim to libdrm. That's at least how it's supposed to
> > be done.
> 
> What's the point of that?
> 
> #include "drm.h"
> 
> works in the kernel as well as in libdrm.

None for this case, was just an example how to handle the userspace
headers since you've said verbatim copy. It shouldn't ever be a verbatim
copy but always go through make headers_install. And it might make sense
to clean this up for all drivers since there's a bunch of random
differences in these. Anyway was just an idea.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list