[Nouveau] [PATCH] nouveau: nv46: Change mc subdev oclass from nv44 to nv4c

[Hans de Goede]

Hi,

On 24-07-15 04:32, Ben Skeggs wrote:
> On 24 July 2015 at 01:20, Hans de Goede <hdegoede at redhat.com> wrote:
>> MSI interrupts appear to not work for nv46 based cards. Change the mc
>> subdev oclass for these cards from nv44 to nv4c, the nv4c mc code is
>> identical to the nv44 mc code except that it does not use msi
>> (it does not define a msi_rearm callback).
> I'm fine with this, but it'd be nice to check that the binary driver
> doesn't/can't use MSI on these too (there might be an alternate method
> we need to use).
>
> Would you be able to grab the latest proprietary driver that works on
> nv4x, and do a mmiotrace of it?  You *might* need to use "modprobe
> nvidia NVreg_EnableMSI=1", because at some point NVIDIA didn't use it
> by default anywhere.

Will do first thing coming monday.

Regards,

Hans


>
> Thanks,
> Ben.
>
>> BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=90435
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> ---
>>   drivers/gpu/drm/nouveau/nvkm/engine/device/nv40.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/nv40.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/nv40.c
>> index c630136..b4ad791 100644
>> --- a/drivers/gpu/drm/nouveau/nvkm/engine/device/nv40.c
>> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/nv40.c
>> @@ -265,7 +265,7 @@ nv40_identify(struct nvkm_device *device)
>>                  device->oclass[NVDEV_SUBDEV_CLK    ] = &nv40_clk_oclass;
>>                  device->oclass[NVDEV_SUBDEV_THERM  ] = &nv40_therm_oclass;
>>                  device->oclass[NVDEV_SUBDEV_DEVINIT] =  nv1a_devinit_oclass;
>> -               device->oclass[NVDEV_SUBDEV_MC     ] =  nv44_mc_oclass;
>> +               device->oclass[NVDEV_SUBDEV_MC     ] =  nv4c_mc_oclass;
>>                  device->oclass[NVDEV_SUBDEV_BUS    ] =  nv31_bus_oclass;
>>                  device->oclass[NVDEV_SUBDEV_TIMER  ] = &nv04_timer_oclass;
>>                  device->oclass[NVDEV_SUBDEV_FB     ] =  nv46_fb_oclass;
>> --
>> 2.4.3
>>
>> _______________________________________________
>> Nouveau mailing list
>> Nouveau at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/nouveau