[PATCH] drm/nouveau/fifo: fix simple_return.cocci warnings

kbuild test robot fengguang.wu at intel.com
Tue Jul 28 04:03:50 PDT 2015


drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c:372:1-4: WARNING: end returns can be simpified

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.

Generated by: scripts/coccinelle/misc/simple_return.cocci

Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---

 gk104.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c
@@ -369,11 +369,7 @@ gk104_fifo_context_ctor(struct nvkm_obje
 	nv_wo32(base, 0x0208, 0xffffffff);
 	nv_wo32(base, 0x020c, 0x000000ff);
 
-	ret = nvkm_vm_ref(nvkm_client(parent)->vm, &base->vm, base->pgd);
-	if (ret)
-		return ret;
-
-	return 0;
+	return nvkm_vm_ref(nvkm_client(parent)->vm, &base->vm, base->pgd);
 }
 
 static void


More information about the dri-devel mailing list