[PATCH 2/2] drm/i915: Soften error messages in i915_gem_object_create_from_data()

Chris Wilson chris at chris-wilson.co.uk
Tue Jul 28 06:27:16 PDT 2015


Since we already return -EFAULT to the user, emitting an error message
*and* WARN is overkill. If the caller is upset, they can do so, but for
the purposes of debugging we need only log the erroneous values.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Cc:: Alex Dai <yu.dai at intel.com>
Cc: Dave Gordon <david.s.gordon at intel.com>
Cc: Tom O'Rourke <Tom.O'Rourke at intel.com>
---
 drivers/gpu/drm/i915/i915_gem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index c1ded76a6eb4..2039798f4403 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -5243,8 +5243,8 @@ i915_gem_object_create_from_data(struct drm_device *dev,
 
 	i915_gem_object_unpin_pages(obj);
 
-	if (WARN_ON(bytes != size)) {
-		DRM_ERROR("Incomplete copy, wrote %zu of %zu", bytes, size);
+	if (bytes != size) {
+		DRM_DEBUG_GEM("Incomplete copy, wrote %zu of %zu", bytes, size);
 		ret = -EFAULT;
 		goto fail;
 	}
-- 
2.4.6



More information about the dri-devel mailing list