[PATCH libdrm] man: remove .man_fixup workaround

Emil Velikov emil.l.velikov at gmail.com
Wed Jul 29 10:04:44 PDT 2015


On 16 July 2015 at 19:05, Jonathan Gray <jsg at jsg.id.au> wrote:
> On Thu, Jul 16, 2015 at 04:55:40PM +0100, Emil Velikov wrote:
>> The whole thing is quite messy - the file is used to indicate that the
>> man pages were correctly generated prior to applying the "fixup" (alias)
>>
>> At the same time we use a rule with the same name, to create the same
>> file if the generation has failed.
>>
>> In other words - it attempts to create the file either way. So there is
>> little point in it and we can remove it.
>>
>> Spotted while attempting to build with bmake which kindly blocked on the
>> following (non compliant construct)
>>
>> .man_fixup: | $(miscman_DATA)
>>
>> Cc: Jonathan Gray <jsg at jsg.id.au>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>> ---
>>
>> Jonathan,
>>
>> With the following patch libdrm build fine on my Arch + bmake.
>> The `dist' target is still broken, yet `all' and `check' work great.
>>
>> Will you guys consider moving back to the upstream build ? As mentioned
>> before if there are problems do mention/file bugs so that we can get
>> them sorted.
>
> Hi Emil,
>
> I've taken a quick look at extracting patches from the OpenBSD version
> and put the result up here:
>
> https://github.com/jonathangray/drm/commits/openbsd
>
> I'm in Canada at the moment so won't be able to test on Radeon for a
> week or so but this seems to work on i915 at least.
>
> Currently we don't duplicate the public drm headers between userland
> and the kernel but we could move back to doing things that
> way.
>
> I can clean those patches up and submit them if you like.
> The xenocara wrapper makefile is just to fit into the
> system makefiles so you can ignore that one.
This and your three patches are in master now.

Hopefully we'll get the remaining diff between libdrm and
{Open,Net,*}BSD sorted in the not too distant future :)

Thanks
Emil


More information about the dri-devel mailing list