[PATCH] libdrm/amdgpu: Fixed drm.h include.

Alex Deucher alexdeucher at gmail.com
Wed Jul 29 13:59:35 PDT 2015


On Tue, Jul 28, 2015 at 10:35 PM, Alexandr Akulich
<akulichalexander at gmail.com> wrote:
> On Wed, Jul 22, 2015 at 1:20 PM, Michel Dänzer <michel at daenzer.net> wrote:
>> On 22.07.2015 16:33, Alexandr Akulich wrote:
>>> On Wed, Jul 22, 2015 at 1:19 PM, Michel Dänzer <michel at daenzer.net> wrote:
>>>> On 17.07.2015 22:33, Alexandr Akulich wrote:
>>>>> As I see, this is not a kernel header, but a local (belongs to libdrm) one.
>>>>> (Otherwise, I would like you to point me on such file at, say,
>>>>> https://github.com/torvalds/linux/tree/master/include/drm)
>>>>
>>>> https://github.com/torvalds/linux/blob/master/include/uapi/drm/amdgpu_drm.h
>>>>
>>>>
>>>>> At files drm_sarea.h, mga_drm.h, qxl_drm.h, radeon_drm.h and via_drm.h we have
>>>>>
>>>>> #include "drm.h"
>>>>>
>>>>> At the same time, at i915_drm.h and tegra_drm.h. we have
>>>>>
>>>>> #include <drm.h>
>>>>>
>>>>> I'm pretty sure that the first case is correct, because drm.h is
>>>>> always would be local file (in the same directory), related to
>>>>> amdgpu_drm.h, and that is why local include "drm.h" would be always
>>>>> valid.
>>>>
>>>> Makes sense to me, the patch is
>>>>
>>>> Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
>>> Thanks! I have no write access to this fd.o repository. Can you apply it please?
>>
>> I assume your patch is against the amdgpu branch of
>> http://cgit.freedesktop.org/~agd5f/drm/, right? Only Alex Deucher has
>> write access to that.
>
> Well, what I can do?
> Alex, can you apply the patch, please?

Applied.  thanks!

Alex


More information about the dri-devel mailing list