[PATCH v3 00/24] rm: fb emulation: Step 1: Create new drm_fb_helper wrapper funcs

Archit Taneja architt at codeaurora.org
Fri Jul 31 03:51:38 PDT 2015


DRM drivers using drm_fb_helpers still call some fbdev core functions.
This makes the driver depend on CONFIG_FB, resulting in complicated
Kconfig options, and preventing us from creating a top level drm config
option to enable/disable FBDEV emulation.

Create new drm_fb_helper functions that replace these fbdev functions.

In most cases, the new helper funcs simply wrap around the original fbdev
functions. For a few (like framebufer_alloc), we actually do some work
that is currently redundant across multiple drivers.

With these patches, the drivers don't call any fbdev functions directly.
They are now called through functions in drm_fb_helper.c. We will later
create a fbdev emulation config option to stub out the fb helpers.

The only exception is vmwgfx driver. This doesn't use drm_fb_helper. It
creates a fb device how a driver in drivers/video/fbdev would. Maybe this
needs to be converted to use drm_fb_helpers.

For more info, have a look at the threads:
http://lists.freedesktop.org/archives/dri-devel/2015-March/078729.html
http://lists.freedesktop.org/archives/dri-devel/2015-March/078975.html

changes in v3:
- Removed drm_fb_helper for remove_conflicting_framebuffers.
- Fixed kerneldoc header errors
- Some fixes pointed out on the mailing list

changes in v2:
- Incorporated comments
- Misc fixes for build wannings/errors
- resend version has v2 changes in changelog, 'compile tested only' is
  removed.

Archit Taneja (24):
  drm/fb_helper: Add drm_fb_helper functions to manage fb_info creation
  drm/fb_helper: Create a wrapper for unlink_framebuffer
  drm/fb_helper: Create wrappers for fb_sys_read/write funcs
  drm/fb_helper: Create wrappers for blit, copyarea and fillrect funcs
  drm/fb_helper: Create a wrapper for fb_set_suspend
  drm/cirrus: Use new drm_fb_helper functions
  drm/rockchip: Use new drm_fb_helper functions
  drm/armada: Use new drm_fb_helper functions
  drm/ast: Use new drm_fb_helper functions
  drm/omap: Use new drm_fb_helper functions
  drm/tegra: Use new drm_fb_helper functions
  drm/msm: Use new drm_fb_helper functions
  drm/exynos: Use new drm_fb_helper functions
  drm/gma500: Use new drm_fb_helper functions
  drm/mgag200: Use new drm_fb_helper functions
  drm/radeon: Use new drm_fb_helper functions
  drm/qxl: Use new drm_fb_helper functions
  drm/i915: Use new drm_fb_helper functions
  drm/nouveau: Use new drm_fb_helper functions
  drm/udl: Use new drm_fb_helper functions
  drm/bochs: Use new drm_fb_helper functions
  drm/amdgpu: Use new drm_fb_helper functions
  drm/virtio: Use new drm_fb_helper functions
  drm/fb_cma_helper: Use new drm_fb_helper functions

 drivers/gpu/drm/Kconfig                       |   7 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c        |  45 ++----
 drivers/gpu/drm/armada/armada_fbdev.c         |  33 ++--
 drivers/gpu/drm/ast/ast_fb.c                  |  48 ++----
 drivers/gpu/drm/bochs/bochs_drv.c             |   4 +-
 drivers/gpu/drm/bochs/bochs_fbdev.c           |  36 ++---
 drivers/gpu/drm/cirrus/cirrus_drv.c           |   4 +-
 drivers/gpu/drm/cirrus/cirrus_fbdev.c         |  41 +----
 drivers/gpu/drm/drm_fb_cma_helper.c           |  45 ++----
 drivers/gpu/drm/drm_fb_helper.c               | 223 ++++++++++++++++++++++++++
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c     |  47 ++----
 drivers/gpu/drm/gma500/accel_2d.c             |   6 +-
 drivers/gpu/drm/gma500/framebuffer.c          |  48 ++----
 drivers/gpu/drm/i915/intel_fbdev.c            |  40 ++---
 drivers/gpu/drm/mgag200/mgag200_fb.c          |  39 +----
 drivers/gpu/drm/msm/msm_fbdev.c               |  34 ++--
 drivers/gpu/drm/nouveau/nouveau_fbcon.c       |  39 ++---
 drivers/gpu/drm/omapdrm/omap_fbdev.c          |  38 ++---
 drivers/gpu/drm/qxl/qxl_fb.c                  |  40 ++---
 drivers/gpu/drm/radeon/radeon_fb.c            |  42 ++---
 drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c |  47 ++----
 drivers/gpu/drm/tegra/fb.c                    |  35 ++--
 drivers/gpu/drm/udl/udl_fb.c                  |  41 ++---
 drivers/gpu/drm/virtio/virtgpu_fb.c           |  32 ++--
 include/drm/drm_fb_helper.h                   |  27 ++++
 25 files changed, 485 insertions(+), 556 deletions(-)

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation



More information about the dri-devel mailing list