[PATCH 05/98] exynos_drm.h: use __u64 from linux/types.h

Frans Klaver fransklaver at gmail.com
Mon Jun 1 02:14:12 PDT 2015


On Mon, Jun 1, 2015 at 11:08 AM, Christian K├Ânig
<christian.koenig at amd.com> wrote:
> Yeah, completely agree with Linus on the visibility problem and that's
> exactly the reason why we don't include <stdint.h> in the kernel header and
> expect userspace to define the ISO types somewhere.
>
> But using the types from "include/linux/types.h" and especially including it
> into the uapi headers doesn't make the situation better, but rather worse.
>
> With this step we not only make the headers depend on another header that
> isn't part of the uapi, but also pollute the user space namespace with __sXX
> and __uXX types which aren't defined anywhere else.

These __uXX and __sXX types are defined in
include/uapi/asm-generic/ll64.h and pulled in by
include/uapi/linux/types.h. Including linux/types.h is therefore
valid.

Frans


More information about the dri-devel mailing list