[PATCH 0/3] Use acpi_video_unregister_backlight instead of acpi_video_unregister in platfrom backlight drivers

Jani Nikula jani.nikula at linux.intel.com
Tue Jun 2 02:59:10 PDT 2015


On Mon, 01 Jun 2015, Hans de Goede <hdegoede at redhat.com> wrote:
> Hi All,
>
> I'm working on cleaning up the currently somewhat convoluted logic to
> select which backlight interfaces to register on x86 systems, see:
> http://lists.freedesktop.org/archives/dri-devel/2014-December/074687.html
>
> For a rought outline (details will change in the actual patch-set).
>
> These 3 patches are a preparation for that work, as the behavior of the
> current code is not always consistent (it changes depending on module
> loading order in some cases). These 3 patches remove this inconsistency
> which in some cases may result in a behavior change.
>
> This way the cleanup can have a consistent base to build upon, and I can
> ensure that the cleanup itself does not cause any functional changes.

Thanks for doing this.

Slightly unrelated, but you'll end up calling:

acpi_video_unregister_backlight
	acpi_video_bus_unregister_backlight
		acpi_video_dev_unregister_backlight
			thermal_cooling_device_unregister

Uhm, err, what? What business does *that* have in the backlight
unregister call chain?! Should that be untangled from the mess too?

BR,
Jani.


>
> I hope to post a v1 of the actual cleanup patch-set in 1-2 weeks.
>
> Regards,
>
> Hans
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Technology Center


More information about the dri-devel mailing list