[PATCH 01/27] drm/bridge: ptn3460: #include <linux/gpio/consumer.h>, depend on GPIOLIB
thierry.reding at gmail.com
Fri Jun 5 04:20:52 PDT 2015
On Tue, May 05, 2015 at 06:32:17PM +0200, Geert Uytterhoeven wrote:
> If GPIOLIB=n and asm-generic/gpio.h is not used:
> drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_pre_enable’:
> drivers/gpu/drm/bridge/ptn3460.c:135: error: implicit declaration of function ‘gpiod_set_value’
> drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_probe’:
> drivers/gpu/drm/bridge/ptn3460.c:333: error: implicit declaration of function ‘devm_gpiod_get’
> drivers/gpu/drm/bridge/ptn3460.c:333: warning: assignment makes pointer from integer without a cast
> drivers/gpu/drm/bridge/ptn3460.c:340: error: implicit declaration of function ‘gpiod_direction_output’
> drivers/gpu/drm/bridge/ptn3460.c:346: warning: assignment makes pointer from integer without a cast
> Add the missing #include <linux/gpio/consumer.h> to fix this.
> As the resulting driver won't work with GPIOLIB=n anyway, make
> DRM_PTN3460 depend on GPIOLIB || COMPILE_TEST.
> Signed-off-by: Geert Uytterhoeven <geert at linux-m68k.org>
> Cc: David Airlie <airlied at linux.ie>
> Cc: dri-devel at lists.freedesktop.org
> drivers/gpu/drm/bridge/Kconfig | 4 ++--
> drivers/gpu/drm/bridge/ptn3460.c | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
Applied, thanks. Note that I dropped the part about adding the GPIOLIB
dependency because that had been attempted previously to fix this, but
it causes recursive dependencies on PowerPC (ppc64_defconfig). I don't
know of a way to untangle those (I tried and failed miserably), so I
think adding the include is really as good as it'll get.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 819 bytes
Desc: not available
More information about the dri-devel