[PATCH] drm/msm/dp: use flags argument of devm_gpiod_get to set direction

Rob Clark robdclark at gmail.com
Mon Jun 15 18:00:17 PDT 2015


On Mon, Jun 15, 2015 at 5:00 PM, Uwe Kleine-König
<u.kleine-koenig at pengutronix.de> wrote:
> On Tue, Jun 09, 2015 at 11:38:45AM +0200, Uwe Kleine-König wrote:
>> Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
>> which appeared in v3.17-rc1, the gpiod_get* functions take an additional
>> parameter that allows to specify direction and initial value for output.
>>
>> Use this to simplify the driver. Furthermore this is one caller less
>> that stops us making the flags argument to gpiod_get*() mandatory.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> gentle ping.
>
> I intend to make the flags parameter mandatory for 4.3. So if this patch
> doesn't make it in for 4.2-rc1 I'd like to take it as part of the
> respective gpio change via the gpio tree.
>
> What's your plan regarding this change?

I had planned to send a second pull request for 4.2 with some
additional hdcp patches that depend on scm changes coming in via
arm-soc tree for 4.2.. if that is ok, I can include this patch with
that second pull req..  otherwise I'm ok with Dave applying it
directly or you taking it in via gpio tree.  Either way is fine by me.

BR,
-R

> Best regards
> Uwe
>
> --
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list