virtio-gpu vq code isn't thread safe

Dave Airlie airlied at gmail.com
Tue Jun 16 00:29:03 PDT 2015


On 16 June 2015 at 17:12, Gerd Hoffmann <kraxel at redhat.com> wrote:
> On Di, 2015-06-16 at 14:55 +1000, Dave Airlie wrote:
>> Hey Gerd,
>>
>> This probably doesn't matter yet, but they virtgpu_vq buffer
>> allocation code you added isn't threadsafe.
>
> Right, I'll add a lock (or do you have a patch already?)

I've got a patch in my tree to add a spinlock around it,

http://cgit.freedesktop.org/~airlied/linux/commit/?h=virtio-gpu&id=e5adb6e41394ac16dbbaffc961e196103f7b07fa

but I'd need to rebase it out and send it, feel free to steal and add
my S-o-b to it.

Dave.


More information about the dri-devel mailing list