[RFC 0/2] drm/msm: HDMI PHY rework for MSM8x94 support

Stephane Viau sviau at codeaurora.org
Tue Jun 16 15:24:07 PDT 2015

The RFC concerns a code restructuring of the HDMI module, which mainly has two

1. architectural 
HDMI registers are divided in two parts: HDMI core and HDMI PHY. The HDMI Core
registers are common to all chipsets sharing the MDP version (MDP5 here). On
the other hand, HDMI PHY registers depend on the interface and process (28nm,
20nm, ...) being used for the same chipsets. Some chipsets (eg: msm8x94) don't
require us to access HDMI PHY registers.
>From a software architecture point of view, it would make sense that all HDMI
PHY registers should only be accessed by (PHY) hdmi_phy_*.c files, while all 
HDMI Core registers are read/written by the (core) hdmi.c and hdmi_connector.c

2. readability 
Once we add msm8x94, which does not program HDMI PHY registers, it will be
easier to handle the HDMI core register programming because a hdmi_phy_*.c
file won't be created for this chipset. Instead of creating such a stub file
or some kind of workaround, it only makes sense to bring the HDMI core register 
programming where it is supposed to be.

To summarize, this re-structuring is to improve the code architecture,
facilitate the introduction of msm8x94 support and won't change the current

Stephane Viau (2):
  [RFC] drm/msm/hdmi: remove ->reset() from HDMI PHY
  drm/msm: Add support for msm8x94

 drivers/gpu/drm/msm/hdmi/hdmi.c           | 30 ++++++----
 drivers/gpu/drm/msm/hdmi/hdmi.h           |  1 -
 drivers/gpu/drm/msm/hdmi/hdmi_bridge.c    |  8 ++-
 drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 94 +++++++++++++++++++++++++------
 drivers/gpu/drm/msm/hdmi/hdmi_phy_8960.c  | 52 -----------------
 drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c  | 32 -----------
 drivers/gpu/drm/msm/hdmi/hdmi_phy_8x74.c  | 57 -------------------
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c   | 73 +++++++++++++++++++++++-
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c   |  8 ++-
 9 files changed, 179 insertions(+), 176 deletions(-)

Qualcomm Innovation Center, Inc.

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

More information about the dri-devel mailing list