[Nouveau] [PATCH 1/6] gr: support for NVIDIA-provided firmwares
gnurou at gmail.com
Thu Jun 18 21:04:24 PDT 2015
On Fri, Jun 19, 2015 at 12:57 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> Why did you change request_firmware to request_firmware_direct?
request_firmware() outputs an error message if the firmware file does
not exist, whereas request_firmware_direct() doesn't. Since the
firmware file can be in one of two locations, that seems to be the
most appropriate behavior.
However, request_firmware_direct() also does not invoke the userspace
helper. In the case of Nouveau I don't believe we need this, but if I
overlooked something let me know and I will think of something else.
More information about the dri-devel