[PATCH 1/2] drm/amdgpu: Initialize compute sdma and memory from kgd

[Oded Gabbay]

On Wed, Jun 24, 2015 at 10:31 PM, Alex Deucher <alexdeucher at gmail.com> wrote:
> On Wed, Jun 24, 2015 at 3:28 PM, Oded Gabbay <oded.gabbay at gmail.com> wrote:
>> On Wed, Jun 24, 2015 at 10:25 PM, Alex Deucher <alexdeucher at gmail.com> wrote:
>>> On Fri, Jun 12, 2015 at 4:08 AM, Oded Gabbay <oded.gabbay at gmail.com> wrote:
>>>> From: Ben Goz <ben.goz at amd.com>
>>>>
>>>> Signed-off-by: Ben Goz <ben.goz at amd.com>
>>>> Acked-by: Oded Gabbay <oded.gabbay at amd.com>
>>>> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
>>>
>>> Does this depend on some other patch?  I'm getting a build failure:
>>> drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c: In function ‘gmc_v7_0_init_compute_vmid’:
>>> drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2038:19: error:
>>> ‘MTYPE_NONCACHED’ undeclared (first use in this function)
>>>   sh_mem_config |= MTYPE_NONCACHED << SH_MEM_CONFIG__DEFAULT_MTYPE__SHIFT;
>>>                    ^
>>> drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2038:19: note: each undeclared
>>> identifier is reported only once for each function it appears in
>>
>> Strange.
>> I just checked it while it is rebased on dave's drm-next and there is no error
>> head of git log:
>> 2015-06-24 - 2095197 -  drm/amdgpu: Initialize compute sdma and memory
>> from kgd <Ben Goz>
>> 2015-06-24 - 8b72ce1 -  (drm/drm-next) drm: Always enable atomic API
>> <Daniel Stone>
>> 2015-06-24 - fa2f97d -  drm/vgem: Set unique to "vgem" <Daniel Vetter>
>> ...
>
> You probably built with CIK support disabled.  It's a kconfig option.
>
> Alex
>
Yeah, totally forgot about it.
I see the error now. I'll send a revised patch soon.
Thanks Alex

>>
>> Oded