[PATCH 1/2] drm: bridge/dw_hdmi: fix register I2CM_ADDRESS register name

Vladimir Zapolskiy vladimir_zapolskiy at mentor.com
Fri Jun 26 07:24:12 PDT 2015


Hello David,

On 08.06.2015 17:17, Vladimir Zapolskiy wrote:
> Hi David, Philipp, Andy, Russell,
> 
> On 19.05.2015 17:39, Andy Yan wrote:
>> Hi Vladimir,
>>    Thanks for you patch.
>>
>> On 2015年05月18日 20:32, Vladimir Zapolskiy wrote:
>>> I2CM_ADDRESS became a MESS, fix it, also change guarding define
>>> to __DW_HDMI_H__ , since the driver is not IMX specific.
>>>
>>> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy at mentor.com>
>>     Acked-by: Andy Yan <andy.yan at rock-chips.com>
>>> ---
>>>   drivers/gpu/drm/bridge/dw_hdmi.h | 8 ++++----
>>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.h b/drivers/gpu/drm/bridge/dw_hdmi.h
>>> index 175dbc8..ee7f7ed 100644
>>> --- a/drivers/gpu/drm/bridge/dw_hdmi.h
>>> +++ b/drivers/gpu/drm/bridge/dw_hdmi.h
>>> @@ -7,8 +7,8 @@
>>>    * (at your option) any later version.
>>>    */
>>>   
>>> -#ifndef __IMX_HDMI_H__
>>> -#define __IMX_HDMI_H__
>>> +#ifndef __DW_HDMI_H__
>>> +#define __DW_HDMI_H__
>>>   
>>>   /* Identification Registers */
>>>   #define HDMI_DESIGN_ID                          0x0000
>>> @@ -525,7 +525,7 @@
>>>   
>>>   /* I2C Master Registers (E-DDC) */
>>>   #define HDMI_I2CM_SLAVE                         0x7E00
>>> -#define HDMI_I2CMESS                            0x7E01
>>> +#define HDMI_I2CM_ADDRESS                       0x7E01
>>>   #define HDMI_I2CM_DATAO                         0x7E02
>>>   #define HDMI_I2CM_DATAI                         0x7E03
>>>   #define HDMI_I2CM_OPERATION                     0x7E04
>>> @@ -1031,4 +1031,4 @@ enum {
>>>   	HDMI_A_VIDPOLCFG_HSYNCPOL_ACTIVE_LOW = 0x0,
>>>   };
>>>   
>>> -#endif /* __IMX_HDMI_H__ */
>>> +#endif /* __DW_HDMI_H__ */
>>
>>
> 
> what would be the next action regarding these two patches? If review is
> done, should they go to drm-dwhdmi-devel or drm-next ?

ping.

--
With best wishes,
Vladimir



More information about the dri-devel mailing list