[PATCH v2] drm/amdgpu: remove unnecessary check before kfree
Alex Deucher
alexdeucher at gmail.com
Fri Jun 26 10:01:24 PDT 2015
On Fri, Jun 26, 2015 at 3:56 AM, Maninder Singh <maninder1.s at samsung.com> wrote:
> kfree(NULL) is safe and this check is probably not required
>
> Signed-off-by: Maninder Singh <maninder1.s at samsung.com>
> Reviewed-by: Vaneet Narang <v.narang at samsung.com>
> Reviewed-by: Christian Konig <christian.koenig at amd.com>
Applied. thanks!
Alex
> ---
> v2: Chnged shortlog prefix - gpu/amdgpu
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index fec487d..a85cd08 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1575,8 +1575,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
> amdgpu_fence_driver_fini(adev);
> amdgpu_fbdev_fini(adev);
> r = amdgpu_fini(adev);
> - if (adev->ip_block_enabled)
> - kfree(adev->ip_block_enabled);
> + kfree(adev->ip_block_enabled);
> adev->ip_block_enabled = NULL;
> adev->accel_working = false;
> /* free i2c buses */
> --
> 1.7.9.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
More information about the dri-devel
mailing list