[PATCH 1/5] drm/cma: use correct fb width/height

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sat Mar 7 09:56:33 PST 2015


Hi Rob,

Thank you for the patch.

On Friday 06 March 2015 16:23:06 Rob Clark wrote:

This deserves an explanation, the reason why this fix is needed is far from 
clear from the code only.

> Signed-off-by: Rob Clark <robdclark at gmail.com>
> ---
>  drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
> b/drivers/gpu/drm/drm_fb_cma_helper.c index cc0ae04..5c1aca4 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -304,7 +304,7 @@ static int drm_fbdev_cma_create(struct drm_fb_helper
> *helper, }
> 
>  	drm_fb_helper_fill_fix(fbi, fb->pitches[0], fb->depth);
> -	drm_fb_helper_fill_var(fbi, helper, fb->width, fb->height);
> +	drm_fb_helper_fill_var(fbi, helper, sizes->fb_width, sizes->fb_height);
> 
>  	offset = fbi->var.xoffset * bytes_per_pixel;
>  	offset += fbi->var.yoffset * fb->pitches[0];

-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list