[PATCH libdrm 1/2] configure: Stop using AM_MAINTAINER_MODE

[Emil Velikov]

On 10 March 2015 at 16:41, Julien Cristau <jcristau at debian.org> wrote:
> On Tue, Mar 10, 2015 at 16:33:17 +0000, Emil Velikov wrote:
>
>> Hi Julien,
>> On 9 March 2015 at 20:28, Julien Cristau <jcristau at debian.org> wrote:
>> > On Mon, Mar  9, 2015 at 12:08:16 +0000, Emil Velikov wrote:
>> >
>> >> By using it, any modifications to configure.ac or the Makefile.am files
>> >> won't trigger a rebuild of the makefiles. Drop the switch from the
>> >> autogen.sh as well.
>> >>
>> > Since it was set to enabled in configure.ac, the above is not true,
>> > unless you explicitly pass --disable-maintainer-mode to configure.
>> >
>> Hmm... you're absolutely correct here. The following commit message
>> should be more appropriate.
>>
>> AM_MAINTAINER_MODE can be used to disable generation of rebuild rules.
>> This is not something we want to condone/support, considering it can
>> cause greater problems than the perceived benefits. Additionally the
>> Automake manual leans towards avoiding the use of AM_MAINTAINER_MODE.
>>
>> http://www.gnu.org/software/automake/manual/html_node/maintainer_002dmode.html
>>
>>
>> That is unless you're in favour of keeping it ? Afaics at least some X
>> components tend to avoid it.
>>
> I don't really care whether it stays or goes, but your new commit
> message looks good to me :)
>
Ack. Thanks for spotting that silly mistake.

-Emil