[RFC][PATCH] amdkfd: Convert timestamping to use 64bit time accessors

Arnd Bergmann arnd at arndb.de
Fri Mar 13 04:24:27 PDT 2015


On Thursday 12 March 2015 10:23:40 John Stultz wrote:
> Convert the timestamping in the amdkfd driver to use
> a timespec64 and 64bit time accessors.
> 
> Cc: Arnd Bergmann <arnd at arndb.de>
> Cc: Oded Gabbay <oded.gabbay at amd.com>
> Cc: David Airlie <airlied at linux.ie>
> Cc: dri-devel at lists.freedesktop.org
> Signed-off-by: John Stultz <john.stultz at linaro.org>
> 

The patch looks good, but I'd always include at least a one-liner
about what it's good for. In this case, the existing code
is completely safe beyond y2038 because you are dealing with
monotonic time, so it's worth mentioning that we do this in
order to kill off all uses of struct timespec.

	Arnd


More information about the dri-devel mailing list