[PATCH 3/3] drm: change connector to tmp_connector

[Daniel Vetter]

On Tue, Mar 17, 2015 at 03:30:28PM +0800, John Hunter wrote:
> This wasn't too harmful since we already look at connector,
> which has the same effect as the loop for any non-cloned configs.
> Only when we have a cloned configuration is it important to look
> at other connectors. Furthermore existing userspace always changes
> dpms on all of them anyway.
> 
> Signed-off-by: JohnHunter <zhjwpku at gmail.com>

Another small one about process: When resending patches please have some
per-patch changelog about what you've changed here. E.g. for this one add
a line like:

v2: Update commit message as per discussion with Daniel.

It's also good practice to cc anyone who took part in previous discussions
of a patch. If you add a line like

Cc: Daniel Vetter <daniel.vetter at ffwll.ch>

at the bottom of the commit message (right above the sob line) then git
send-email will automatically pick it up. This way people won't miss your
next patch iteration in the flood of mails they tend to get ;-)

Anyway thanks a lot for your patches, I've merged 1&3 from this series to
drm-misc.
-Daniel

> ---
>  drivers/gpu/drm/drm_atomic_helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index 20376e6..93b467d 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -2004,10 +2004,10 @@ retry:
>  	WARN_ON(!drm_modeset_is_locked(&config->connection_mutex));
>  
>  	list_for_each_entry(tmp_connector, &config->connector_list, head) {
> -		if (connector->state->crtc != crtc)
> +		if (tmp_connector->state->crtc != crtc)
>  			continue;
>  
> -		if (connector->dpms == DRM_MODE_DPMS_ON) {
> +		if (tmp_connector->dpms == DRM_MODE_DPMS_ON) {
>  			active = true;
>  			break;
>  		}
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch