[RFC PATCH 05/37] drm: Exynos: Remove mode validation inside mode_fixup

Daniel Vetter daniel at ffwll.ch
Fri Mar 20 08:59:42 PDT 2015


On Thu, Mar 19, 2015 at 04:33:04AM +0000, Daniel Stone wrote:
> mode_valid is the callback we already have to check whether or not a
> mode is valid. So there's no need to validate again inside mode_fixup,
> and there's really very definitely no need to select a totally different
> mode.

There is. mode_fixup is called for modeset, mode_valid by the probe
helpers. But userspace can just ignore the mode list and add their owns.
So yeah you'll need to validate twice.

Fixing that up is somewhere on my todo ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list