[PATCH v2 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL

Jeff Epler jepler at unpythonic.net
Tue Mar 24 07:29:27 PDT 2015


[for just patch 1/4; I didn't look as closely at the others]
Reviewed-by: Jeff Epler <jepler at unpythonic.net>

...with one half of a caveat (rounded up?): Like most or all of the
originals, and like DIV_ROUND_CLOSEST just above it in kernel.h, the new
code gives an incorrect answer if the temporary overflows at
+	unsigned long long _tmp = (x) + (__d) / 2;

As a doc improvement a remark could be added to a number of these
functions, but there's little reason for that to be part of this series.

Jeff


More information about the dri-devel mailing list