[PATCH libdrm 2/3] tests/drmsl: Extract tests out of xf86drmSL.c

[Emil Velikov]

On 24/03/15 23:06, Jan Vesely wrote:
> v2: merge tests creation and xf86drmSL cleanup
>     rename tests/drmsltest -> tests/drmsl
>     move the test out of libudev test block
> 
> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> ---
> 
> Hi Emil,
> I know you send your R-b on the earlier version, but I thought the changes
> were big enough to send v2. I modeled it after you test splitting series.
> 
> jan
> 
>  .gitignore        |   1 +
>  tests/Makefile.am |   5 +-
>  tests/drmsl.c     | 172 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  xf86drmSL.c       | 172 ++----------------------------------------------------
>  4 files changed, 183 insertions(+), 167 deletions(-)
>  create mode 100644 tests/drmsl.c
> 
> diff --git a/.gitignore b/.gitignore
> index 06cc928..cb7128d 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -74,6 +74,7 @@ tdfx.kld
>  via.kld
>  tests/auth
>  tests/dristat
> +tests/drmsl
>  tests/drmstat
>  tests/getclient
>  tests/getstats
Hmm this reminds me that I missed out updating the .gitignore with my
series.

> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 10f54e3..ad70314 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -35,6 +35,9 @@ if HAVE_NOUVEAU
>  SUBDIRS += nouveau
>  endif
>  
> +TESTS = \
> +	drmsl
> +
>  if HAVE_LIBUDEV
>  
>  check_LTLIBRARIES = libdrmtest.la
> @@ -52,7 +55,7 @@ XFAIL_TESTS =					\
>  	auth					\
>  	lock
>  
> -TESTS =						\
> +TESTS +=					\
>  	openclose				\
>  	getversion				\
>  	getclient				\
You will need the following hunk, otherwise drmsl will not end up in the
check target. Although when I think about it there isn't much value in
running this at make check time. I'll leave the decision up-to you.

--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -61,6 +61,7 @@ TESTS =                                               \
        updatedraw                              \
        name_from_fd

+endif
+
 check_PROGRAMS += $(TESTS)

-endif


As before haven't explicitly checked the moved code so

Acked-by: Emil Velikov <emil.l.velikov at gmail.com>

Thanks
Emil